Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: duplexify #39519

Closed
wants to merge 18 commits into from
Closed

stream: duplexify #39519

wants to merge 18 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 25, 2021 •
edited

  • Introduce Duplex.from.
  • Move out makeDuplex from compose.
  • Add support for { readable, writable } pairs and Promise.
  • Add support for web streams in compose, pipeline and finished.

@ronag ronag requested a review from mcollina July 25, 2021 18:18
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Jul 25, 2021
@ronag
Copy link
Member Author

ronag commented Jul 25, 2021

@nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 25, 2021
@ronag ronag force-pushed the duplexify branch 4 times, most recently from f2b9ae6 to 7904fb0 Compare July 25, 2021 18:34
aduh95
aduh95 reviewed Jul 25, 2021
View reviewed changes
lib/internal/streams/duplexify.js Outdated Show resolved Hide resolved
lib/stream.js Outdated Show resolved Hide resolved
@ronag ronag mentioned this pull request Jul 26, 2021
Closed
@ronag ronag force-pushed the duplexify branch 5 times, most recently from 0bbf146 to 5a8110f Compare July 26, 2021 08:43
@ronag ronag requested review from aduh95 and mcollina July 26, 2021 08:50
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jul 26, 2021
natalaglenn7
natalaglenn7 suggested changes Jul 26, 2021
View reviewed changes
Copy link

@natalaglenn7 natalaglenn7 left a comment •
edited by benjamingr

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39270/

@ronag ronag force-pushed the duplexify branch 7 times, most recently from dd724f6 to ce3b597 Compare July 26, 2021 09:11
@ronag ronag self-assigned this Aug 16, 2021
ronag added a commit to nxtedition/node that referenced this pull request Aug 20, 2021
@ronag
stream: duplexify
defc2b4 
PR-URL: nodejs#39519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@ronag ronag mentioned this pull request Aug 20, 2021
Closed
ronag added a commit to nxtedition/node that referenced this pull request Aug 20, 2021
@ronag
stream: duplexify
2eb474e 
PR-URL: nodejs#39519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <ckbenjamingr@gmail.com>
Backport-PR-URL: nodejs#39820
@ronag
Copy link
Member Author

ronag commented Aug 20, 2021

@danielleadams 533cafc

@targos targos mentioned this pull request Aug 22, 2021
Closed
ronag added a commit to nxtedition/node that referenced this pull request Aug 23, 2021
@ronag
stream: duplexify
ea09812 
PR-URL: nodejs#39519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <ckbenjamingr@gmail.com>
Backport-PR-URL: nodejs#39820
targos pushed a commit that referenced this pull request Aug 23, 2021
@ronag @targos
stream: duplexify
a6d50a1 
PR-URL: #39519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <ckbenjamingr@gmail.com>
Backport-PR-URL: #39820
targos added a commit that referenced this pull request Aug 25, 2021
@targos
2021-08-25, Version 16.8.0 (Current)
93553dc 
Notable changes:

doc:
  * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) #38906
stream:
  * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) #39519
  * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) #39628
util:
  * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) #39814

PR-URL: #39875
@targos targos mentioned this pull request Aug 25, 2021
Merged
targos added a commit that referenced this pull request Aug 25, 2021
@targos
2021-08-25, Version 16.8.0 (Current)
31772a4 
Notable changes:

doc:
  * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) #38906
stream:
  * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) #39519
  * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) #39628
util:
  * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) #39814

PR-URL: #39875
wwwzbwcom pushed a commit to wwwzbwcom/node that referenced this pull request Aug 26, 2021
@targos @wwwzbwcom
2021-08-25, Version 16.8.0 (Current)
10918f4 
Notable changes:

doc:
  * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) nodejs#38906
stream:
  * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) nodejs#39519
  * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) nodejs#39628
util:
  * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) nodejs#39814

PR-URL: nodejs#39875
codebytere added a commit to electron/electron that referenced this pull request Aug 30, 2021
@codebytere
stream: duplexify
e47f56e 
nodejs/node#39519
jkleinsc pushed a commit to electron/electron that referenced this pull request Aug 31, 2021
@electron-roller @codebytere
chore: bump node to v16.8.0 (main) (#30714)
c1075de 
* chore: bump node in DEPS to v16.8.0

* build: add option to hide console window

nodejs/node#39712

* chore: fixup patch indices

* stream: duplexify

nodejs/node#39519

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
debadree25 added a commit to debadree25/node that referenced this pull request Jan 7, 2023
@debadree25
stream: add webstreams to duplex
4937598 
Refs: nodejs#39519
Refs: nodejs@6d06b1c
@debadree25 debadree25 mentioned this pull request Jan 7, 2023
Closed
debadree25 added a commit to debadree25/node that referenced this pull request Jan 12, 2023
@debadree25
lib: add webstreams to Duplex.from()
b09cb7c 
Refs: nodejs#39519
@debadree25 debadree25 mentioned this pull request Jan 12, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request Jan 19, 2023
@debadree25
lib: add webstreams to Duplex.from()
49413ad 
Refs: #39519
PR-URL: #46190
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@debadree25 @RafaelGSS
lib: add webstreams to Duplex.from()
68cde4c 
Refs: #39519
PR-URL: #46190
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
debadree25 added a commit to debadree25/node that referenced this pull request Feb 27, 2023
@debadree25
lib: add webstreams to Duplex.from()
7e23a16 
Refs: nodejs#39519
PR-URL: nodejs#46190
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
debadree25 added a commit to debadree25/node that referenced this pull request Feb 27, 2023
@debadree25
lib: add webstreams to Duplex.from()
74eba8e 
Refs: nodejs#39519
PR-URL: nodejs#46190
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
debadree25 added a commit to debadree25/node that referenced this pull request May 23, 2023
@debadree25
lib: add webstreams to Duplex.from()
2c1a619 
Refs: nodejs#39519
PR-URL: nodejs#46190
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams pushed a commit that referenced this pull request May 29, 2023
@debadree25 @danielleadams
lib: add webstreams to Duplex.from()
d449b73 
Refs: #39519
PR-URL: #46190
Backport-PR-URL: #46314
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

@aduh95 aduh95 aduh95 left review comments

@natalaglenn7 natalaglenn7 natalaglenn7 requested changes

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees

@ronag ronag

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ronag @nodejs-github-bot @mcollina @danielleadams @jasnell @benjamingr @targos @aduh95 @natalaglenn7