Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.6] CJS runs repeatedly when there are circular dependencies when loaded by ESM #49497

Closed
liuxingbaoyu opened this issue Sep 5, 2023 · 25 comments · Fixed by #49500
Closed

[v20.6] CJS runs repeatedly when there are circular dependencies when loaded by ESM #49497

liuxingbaoyu opened this issue Sep 5, 2023 · 25 comments · Fixed by #49500
Labels
confirmed-bug Issues with confirmed bugs. esm Issues and PRs related to the ECMAScript Modules implementation. module Issues and PRs related to the module subsystem.

Comments

@liuxingbaoyu
Copy link
Contributor

liuxingbaoyu commented Sep 5, 2023 •
edited

Version

v20.6.0

Platform

all

Subsystem

No response

What steps will reproduce the bug?

https://github.com/liuxingbaoyu/node-v20.6-bug

How often does it reproduce? Is there a required condition?

always

What is the expected behavior? Why is that the expected behavior?

node .\main.js
run
success

What do you see instead?

node .\main.js
run
run
success

Additional information

This should be the regression introduced by v20.6.
@liuxingbaoyu liuxingbaoyu changed the title [v20.6] CJS cycle dependency throwing error is loaded by ESM [v20.6] CJS cycle dependencies throw an error when being loaded by ESM Sep 5, 2023
@liuxingbaoyu liuxingbaoyu mentioned this issue Sep 5, 2023
Closed
1 task
@liuxingbaoyu liuxingbaoyu changed the title [v20.6] CJS cycle dependencies throw an error when being loaded by ESM [v20.6] CJS runs repeatedly when there are circular dependencies when loaded by ESM Sep 5, 2023
@lilnasy lilnasy mentioned this issue Sep 5, 2023
Closed
1 task
kunish added a commit to MetaCubeX/metacubexd that referenced this issue Sep 5, 2023
@kunish
fix: build issue, Cannot redefine property: File
b50c41e 
See nodejs/node#49497
matz3 added a commit to SAP/ui5-cli that referenced this issue Sep 5, 2023
@matz3
[INTERNAL] Azure Pipelines: Switch back to Node 20.5.x
2e06f6b 
There are issues with the current Node 20.6.0 version.
See: nodejs/node#49497
@Yogu Yogu mentioned this issue Sep 5, 2023
Closed
1 task
@nicolo-ribaudo
Copy link
Contributor

nicolo-ribaudo commented Sep 5, 2023 •
edited

Note that this is breaking@babel/core, and thus all the frameworks/project that use it. It would be great to prioritize it 🙏

@targos
Copy link
Member

targos commented Sep 5, 2023

Can someone give a reproducible example? The code from https://github.com/liuxingbaoyu/node-v20.6-bug doesn't show the problem (it throws an error in mod/index.js).

@liuxingbaoyu
Copy link
Contributor Author

Sorry, I forgot to push the second commit.
But the initial error is also different due to the regression.

@liuxingbaoyu
Copy link
Contributor Author

Please try again, thanks!

@nicolo-ribaudo

This comment was marked as outdated.

Sign in to view
@nicolo-ribaudo
Copy link
Contributor

A minimal reproduction:

// index.mjs
import "./dep.cjs";
// dep.cjs
require("./dep.cjs");
console.log("RUNNING");

Running node index.mjs logs twice but it should log once.

@targos
Copy link
Member

targos commented Sep 5, 2023

I have a repro. Starting to bisect.

matz3 added a commit to SAP/ui5-project that referenced this issue Sep 5, 2023
@matz3
[INTERNAL] Azure Pipelines: Switch back to Node 20.5.x
83fae6c 
There are issues with the current Node 20.6.0 version.
See: nodejs/node#49497
@matz3 matz3 mentioned this issue Sep 5, 2023
Merged
matz3 added a commit to SAP/ui5-project that referenced this issue Sep 5, 2023
@matz3
[INTERNAL] Azure Pipelines: Switch back to Node 20.5.x
98672ae 
There are issues with the current Node 20.6.0 version.
See: nodejs/node#49497
@nicolo-ribaudo
Copy link
Contributor

nicolo-ribaudo commented Sep 5, 2023 •
edited

@targos If it helps, it looks like the problem is that ESM's CJS loader doesn't set this loaded = true before evaluating the CJS module.

Here probably:

node/lib/internal/modules/esm/translators.js

Line 326 in 5b31ff1

cjsParseCache.set(module, { source, exportNames });

@targos
Copy link
Member

targos commented Sep 5, 2023

Bug is introduced by #47999

@kachick kachick mentioned this issue Sep 5, 2023
Merged
2 tasks
flovogt added a commit to SAP/ui5-logger that referenced this issue Sep 5, 2023
@flovogt
[INTERNAL] Azure Pipelines: Switch back to Node 20.5.x
1e690f7 
There are issues with the current Node 20.6.0 version.
See: nodejs/node#49497
@flovogt flovogt mentioned this issue Sep 5, 2023
Merged
flovogt added a commit to SAP/ui5-logger that referenced this issue Sep 5, 2023
@flovogt
[INTERNAL] Azure Pipelines: Switch back to Node 20.5.x
1862514 
There are issues with the current Node 20.6.0 version.
See: nodejs/node#49497
matz3 added a commit to SAP/ui5-cli that referenced this issue Sep 5, 2023
@matz3
[INTERNAL] Azure Pipelines: Switch back to Node 20.5.x
ea59f52 
There are issues with the current Node 20.6.0 version.
See: nodejs/node#49497
@nicolo-ribaudo nicolo-ribaudo mentioned this issue Sep 5, 2023
Merged
matz3 added a commit to SAP/ui5-cli that referenced this issue Sep 5, 2023
@matz3
[INTERNAL] Azure Pipelines: Switch back to Node 20.5.x
99a23f2 
There are issues with the current Node 20.6.0 version.
See: nodejs/node#49497
@nicolo-ribaudo
Copy link
Contributor

In case there is no easy fix, would it be possible to revert that PR?

(cc @aduh95)

@aduh95
Copy link
Contributor

aduh95 commented Sep 5, 2023

Thanks for the ping, I'll have a look

@aduh95 aduh95 mentioned this issue Sep 5, 2023
Merged
@timotheeguerin timotheeguerin mentioned this issue Sep 5, 2023
Closed
@SimenB SimenB mentioned this issue Sep 7, 2023
Merged
@MarkMcCulloh MarkMcCulloh mentioned this issue Sep 7, 2023
Merged
This was referenced Sep 7, 2023
Closed
Closed
mergify bot pushed a commit to winglang/wing that referenced this issue Sep 7, 2023
@MarkMcCulloh
chore: pin node to 20.5.1 in ci (#4115)
442df9a 
Fixes #4099

Waiting for nodejs/node#49497 to be released

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@2501babe 2501babe mentioned this issue Sep 7, 2023
Merged
@buffalojoec buffalojoec mentioned this issue Sep 7, 2023
Closed
@bluwy bluwy mentioned this issue Sep 8, 2023
Merged
@slorber slorber mentioned this issue Sep 8, 2023
Closed
7 tasks
@nicolo-ribaudo nicolo-ribaudo mentioned this issue Sep 8, 2023
Merged
@nicolo-ribaudo
Copy link
Contributor

For people watching issue this for the error with Babel: we added a workaround in @babel/core, @babel/traverse and @babel/types 7.22.17. Please make sure to upgrade and they should be compatible with Node.js 20.6.0.

fisker added a commit to prettier/prettier that referenced this issue Sep 9, 2023
@fisker
Unpin Node.js v20 version
d0c5818 
nodejs/node#49497 has been fixed and released.
@fisker fisker mentioned this issue Sep 9, 2023
Merged
4 tasks
@jorenvandeweyer jorenvandeweyer mentioned this issue Sep 9, 2023
Closed
18 tasks
@legobeat legobeat mentioned this issue Sep 9, 2023
Merged
2 tasks
mxschmitt added a commit to mxschmitt/playwright that referenced this issue Sep 9, 2023
@mxschmitt
Revert "chore: pin node to 20.5 to work around nodejs/node#49497 (mic…
4b779b6 
…rosoft#26921)"

This reverts commit 874e285.
@jkowalleck jkowalleck mentioned this issue Sep 10, 2023
Merged
@oljekechoro oljekechoro mentioned this issue Sep 11, 2023
Closed
2 tasks
@edivados edivados mentioned this issue Sep 12, 2023
Closed
2 tasks
lancetipton added a commit to lancetipton/parkin that referenced this issue Sep 12, 2023
@lancetipton
fix: lock node version in CI
15a0f4e 
* My guess is, it's related to this => nodejs/node#49497
* But could be something else. Seems to only happen in 20.6.0
@lancetipton lancetipton mentioned this issue Sep 12, 2023
Open
This was referenced Sep 13, 2023
Closed
Closed
travi added a commit to semantic-release/semantic-release that referenced this issue Sep 16, 2023
@travi
feat(node-versions): raised the minimum supported node version w/in t…
b93bef4 
…he v20 range to v20.6.1

because of a known issue with v20.6.0 that we might as well avoid since we are restricting the
supported ranges at this point anyway: nodejs/node#49497

BREAKING CHANGE: the minimum supported version for the v20 range of node has been raised slightly to
v20.6.1 to avoid a known node bug
@Qodestackr
Copy link

Qodestackr commented Sep 18, 2023 •
edited

Anyone with a Quick fix, or which version is stable?
My version: v20.6.0

@meyfa
Copy link
Contributor

meyfa commented Sep 18, 2023

v20.6.1 is stable.

Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this issue Oct 27, 2023
@pavelfeldman @Germandrummer92
chore: pin node to 20.5 to work around nodejs/node#49497 (microsoft#2…
c2dc811 
…6921)

Works around nodejs/node#49497
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@aduh95 @alexfernandez
esm: fix loading of CJS modules from ESM
d5305bf 
PR-URL: nodejs#49500
Fixes: nodejs#49497
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
bjoluc added a commit to jspsych/jsPsych that referenced this issue Nov 8, 2023
@bjoluc
Unpin Node v20 since nodejs/node#49497 is fixed
a192ac6
riddla pushed a commit to tricks-gmbh/nuxt-image that referenced this issue Mar 1, 2024
@danielroe @riddla
ci: run tests on node 20.5 until hotfix arrives
7958325 
nodejs/node#49497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. esm Issues and PRs related to the ECMAScript Modules implementation. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

esm: fix loading of (recursive) CJS modules from ESM aduh95/node