-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should Corepack stay in the Node.js distribution? #1697
Conversation
Didn't work:
how can I handle this? |
In case you wonder, the correct command is |
@nodejs/tsc please vote. |
I couldn't sign it with SSH key. Is GPG the only way? |
No, GitHub supports different kind of signatures, including SSH and PGP. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Its been a week should we close it? |
This comment was marked as resolved.
This comment was marked as resolved.
FWIW what worked for me (I already have GPG keys installed locally, that is, I can use
|
@anonrig would using the UI instead of using the script be an option for you? |
I would like to close this vote, and for this effect, I'm revealing my key part:
|
I would like to close this vote, and for this effect, I'm revealing my key part:
|
Election resultsSubject: Should Corepack stay in the Node.js distribution? ResultsWinning candidate: Phase out later: stop distributing Corepack (i.e. the distribution will no longer contain a Table of results
Voting dataParticipants:
Private key to decrypt ballots
Discarded commitsSome commits have not been taken into account when counting the ballots: [
{
"commitInfo": {
"sha": "17fae0a86603c2c9f7b850835fe82e797afec4d6",
"signatureStatus": "E",
"author": "RafaelGSS <rafael.nunu@hotmail.com>",
"files": [
"votes/e4f313dc-6121-47bb-830d-d85f80d6ee33/RafaelGSS.json"
]
},
"reason": "The commit author (RafaelGSS <rafael.nunu@hotmail.com>) is not in the list of allowed voters."
}
] Footnotes
|
Will corepack stay maintained or be deprecated? |
It will not be deprecated, simply will not be distributed along with Node.js but needs to be installed separately |
To clarify, it could be deprecated at some point, that vote does not define anything about deprecation status of Corepack, only how it is distributed. That being said, there are no plans to deprecate Corepack at the moment, and in any case, it will be maintained at least as long as Node.js 24.x is not EOL. |
Are there any further details on the decision or discussion here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
More context is in the PR that triggered the voting automation: Which also contains some links to other older discussions either directly or indirectly... On a side note, maybe the automation should include a link to the vote proposal PR in the actual voting PR, I had to dig this one up from the search because the proposal PR was quite old since it dragged on for ~1y. I added at least #1527 to the top of this PR in case it appears to be coming out of nowhere (although, that PR also appeared to be coming out of nowhere due to the lack of links in the OP even though it was triggered by a bunch of other discussions that I cannot dig the links up easily now because they are scattered across multiple repos IIRC) |
will corepack be distributed as a standalone library ? |
@guiyumin It already is. |
"Yes, it should stay." - literally everyone that isn't one of the |
Given that this issue is likely to attract a number of possibly heated comments from the ecosystem, I'm locking and limiting discussion on the thread to collaborators only. The TSC recognizes that some subset of Node.js users will be disappointed by the outcome here... honestly there was a fair amount of disagreement among collaborators on this which is why it had to go to a TSC vote in the first place. However, the decision has been made and we're progressing along those lines. |
Background: #1527
Vote instructions:
To close the vote, at least 3 secret holder(s)1 must run the following command:
git node vote https://github.com/nodejs/TSC/pull/1697 --decrypt-key-part --post-comment
/cc @nodejs/tsc
Current estimated participation: 94.44%
Footnotes
secret holders are folks who have access to the private key associated with a public key on hkps://keys.openpgp.org that references an email address listed on the TSC voting member list at the time of the opening of the vote. ↩