Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
base: 78cd8263354705b767ef8c6a651740efe4931ba0
Choose a base ref
...
head repository: nodejs/node
compare: 82e475dc75751df08d80bd6e25926bd25c1794f2
Choose a head ref
  • 12 commits
  • 1,343 files changed
  • 5 contributors

Commits on Apr 11, 2018

  1. deps: update V8 to 6.6.346.23 

    PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @MylesBorins
    MylesBorins committed Apr 11, 2018
    Copy the full SHA
    12a1b9b View commit details
    Browse the repository at this point in the history

  2. build: reset embedder string to "-node.0" 

    PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @MylesBorins
    MylesBorins committed Apr 11, 2018
    Copy the full SHA
    1a3f55f View commit details
    Browse the repository at this point in the history

  3. src: update NODE_MODULE_VERSION to 63 

    Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 6.6.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @MylesBorins
    MylesBorins committed Apr 11, 2018
    Copy the full SHA
    1f33c36 View commit details
    Browse the repository at this point in the history

  4. deps: update v8.gyp 

    Synchronize source files list with upstream's BUILD.gn.

PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @targos @MylesBorins
    targos authored and MylesBorins committed Apr 11, 2018
    Copy the full SHA
    85ccb63 View commit details
    Browse the repository at this point in the history

  5. build: update node.gyp to reference gypfiles/v8.gyp 

    Refs: v8/v8@f9934aa
Fixes: nodejs/node-v8#36

PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @joyeecheung @MylesBorins
    joyeecheung authored and MylesBorins committed Apr 11, 2018
    Copy the full SHA
    dd49677 View commit details
    Browse the repository at this point in the history

  6. build: add option to build v8 with GN 

    PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @hashseed @MylesBorins
    hashseed authored and MylesBorins committed Apr 11, 2018
    2
    Copy the full SHA
    5c93b3b View commit details
    Browse the repository at this point in the history

  7. deps: split v8_monolith target into separate file 

    Even if we only use v8_monolith build target, other targets
in v8.gyp with possibly outdated file lists are parsed and
could cause build to fail even with --build-v8-with-gn.

PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @hashseed @MylesBorins
    hashseed authored and MylesBorins committed Apr 11, 2018
    Copy the full SHA
    17d4368 View commit details
    Browse the repository at this point in the history

  8. tools: fix make test-v8 

    PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @targos @MylesBorins
    targos authored and MylesBorins committed Apr 11, 2018
    Copy the full SHA
    3e6ff85 View commit details
    Browse the repository at this point in the history

  9. tools: implement ninja build with --build-v8-with-gn 

    PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @hashseed @MylesBorins
    hashseed authored and MylesBorins committed Apr 11, 2018
    Copy the full SHA
    3fb8abf View commit details
    Browse the repository at this point in the history

  10. test: remove test for shared array buffers transfer 

    PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @malcolmdwhite @MylesBorins
    malcolmdwhite authored and MylesBorins committed Apr 11, 2018
    Copy the full SHA
    24ec796 View commit details
    Browse the repository at this point in the history

  11. util: add type check functions for BigInt arrays 

    Adds `isBigInt64Array` and `isBigUint64Array`.

PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @targos @MylesBorins
    targos authored and MylesBorins committed Apr 11, 2018
    Copy the full SHA
    01c9575 View commit details
    Browse the repository at this point in the history

  12. test: fix promise message test after V8 update 

    PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @targos @MylesBorins
    targos authored and MylesBorins committed Apr 11, 2018
    Copy the full SHA
    82e475d View commit details
    Browse the repository at this point in the history